fix: playbook parameter docs #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for canarychecker canceled.
|
|
Can we add snippet examples for each of the param types? And maybe use a kitchen sink example with all options: |
adityathebe
force-pushed
the
fix/playbook-parameter-docs
branch
from
8db3324
to
d7e464e
Compare
moshloop
reviewed
Oct 2, 2024
|
@adityathebe - Can you also check any vale lint errors ? We probably need to force value to exit on error, and only run it on changed files with something like: https://github.com/marketplace/actions/changed-files |
adityathebe
force-pushed
the
fix/playbook-parameter-docs
branch
7 times, most recently
from
a10faf3
to
968627b
Compare
|
@moshloop added vale checks on changed files. Added few more words on the ignore list and sorted it. |
moshloop
reviewed
Oct 7, 2024
adityathebe
force-pushed
the
fix/playbook-parameter-docs
branch
from
968627b
to
820248d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #224
not sure exactly what #224 was pointing to but I have made some improvements.